[two_auctions] Fix conditional expectation simulation#652
Merged
Conversation
|
📖 Netlify Preview Ready! Preview URL: https://pr-652--sunny-cactus-210e3e.netlify.app (8a7206b) 📚 Changed Lecture Pages: two_auctions |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the conditional expectation simulation for the two auctions lecture. The issue was that the simulation was using pre-sorted valuations instead of fresh random draws, causing a systematic discrepancy between analytical and simulated results.
Key Changes:
- Added code to redraw random valuations before computing simulated bids
- Removed outdated comments about discrepancy that no longer apply after the fix
- The fix ensures
evaluate_largestreceives unsorted random values as intended
Contributor
|
thank you @oyamad |
Contributor
|
@HumphreyYang this looks good. I will merge this later today if you want to have a quick look. |
Member
|
📖 Netlify Preview Ready! Preview URL: https://pr-652--sunny-cactus-210e3e.netlify.app (644e9d3) 📚 Changed Lecture Pages: two_auctions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
Looking at such a figure which exhibits a systematic discrepancy, one should suspect that there should be a bug somewhere.
The values in the array
vin this linelecture-python.myst/lectures/two_auctions.md
Line 434 in 33416c7
evaluate_largest.After